👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

The issue was fixed in e445b1c 💚

   ___  ___    _   ___ _    ___ 
  / _ \| _ \  /_\ / __| |  | __|
 | (_) |   / / _ \ (__| |__| _| 
  \___/|_|_\/_/ \_\___|____|___|
                                
"Connected to Oracle server in tenancy AD-2, South UK"
winget install Git.Git
winget install Microsoft.DotNet.SDK.8
[Riverside].Respire
"Found: Octokit.GraphQL.UnitTests"
"Found: Octokit.GraphQL.IntegrationTests"
"Other projects found, but are .NET Libraries. Will not deploy, but will still provide build results."
[Riverside].ApplicationHostServices
"Build started at 10:12..."
"Build completed at 10:13 and took 1 minutes"
[Riverside].ApplicationHostGateway
"Compiling log"
"Log returned to debug gateway"

HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
Connection.Run(String query, CancellationToken cancellationToken) line 211
ConnectionTests.Run_Specifies_Cancellation_Token() line 73

HttpContent.LoadIntoBufferAsyncCore(Task serializeToStreamTask, MemoryStream tempBuffer)
HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)

FWIW I would consider this a breaking change due to the runtime upgrade, though I think it's a good idea given that .NET Core 3.1 was end of life'd in December 2022.

This path no longer exists because of the upgrade, causing an error with the CI

Is this part of ${{ env.OG_PACK_PROJ_PATH }}?

@Lamparter I fixed the CI. Could you:

• Tell me if this is already published AoT and works well?
• Squash my these 17 commits? (GH Desktop > History > Select them > right click to Squash but you have to rebase first Branch > Rebase > Select origin/main)

FWIW I would consider this a breaking change due to the runtime upgrade, though I think it's a good idea given that .NET Core 3.1 was end of life'd in December 2022.

@kfcampbell Are you wanting to bump the version up here?

FWIW I would consider this a breaking change due to the runtime upgrade, though I think it's a good idea given that .NET Core 3.1 was end of life'd in December 2022.

[redacted] Are you wanting to bump the version up here?

I already bumped it. They were talking about marking this pr as a breaking change because I'd updated it.

Any reason this is still in draft? Builds in CI are completely broken due to the dependency on the .NET Core 3.1 SDK. I could just bump the SDK in my PR, but it would make more sense to just wait on this if it's going to get finished/merged.